Also, I'm not clear on full pay vs partial pay. If they deduct #1 from his pay for being on the NFI is that sufficient to keep him from accruing a season...
Yes, it would.
This usually comes up with undrafted free agents and late round draftees who are not likely to make the active roster.
Most of these players are signed to contracts that include a term called split salary.
A player will receive his full salary if he makes the roster and a much smaller amount if he ends up on injured reserve.
First and second round players often have fully or partially guaranteed contracts because there is almost no chance of them not making the roster.
They don't have split salary clauses.
Dallas guaranteed La'el Collins' entire undrafted contract following the events that led to him tumbling out of the 2015 draft.
Ron Leary had a large portion of his rookie salary guaranteed, but he was released following training camp and spent almost the entire season on the practice squad. He didn't get 6 games as a rookie and the contract tolled (carried over) to the following year.
Regarding Jaylon Smith, I expected Dallas to guarantee his rookie salary despite the injury and that he would accrue a season towards unrestricted free agency.
The part I find confusing now is why Smith's contract will still end after the 2019 season instead of having this year toll so that it would end after the 2020 campaign.
I did find a bit on contracts and players that are on PUP as a result of a non football injury do not accrue a season of service.
NFI is the same as PUP.
Calculation: A player gets 1 AS for each season: 1) they are under contract with a team and 2) they are on full pay status (Active/Inactive roster and Injured Reserve list for 6 or more regular season games). Players do not qualify if they are on the Physically Unable to Perform (PUP) list as a result of a non-football injury, the Practice Squad, or the Exempt Commissioner Permission List.
link